-
Notifications
You must be signed in to change notification settings - Fork 14k
More iter().last() -> last(), iter().next() -> first()
#145402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r=me |
|
also filed rust-lang/rust-clippy#15487 |
This comment has been minimized.
This comment has been minimized.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done in the cg_clif repo instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjorn3 since these are not slices (and cause the errors on CI), is it worth it to go through the individual values/targets to avoid an iter().next() call? (I guess you could compare the entire values array to a [packed 0u128]).
If so, I'll open a PR to the cg_clif.
|
☔ The latest upstream changes (presumably #146185) made this pull request unmergeable. Please resolve the merge conflicts. |
|
probably won't land this, too busy with new job |
r? @estebank
Follow-up to #145401, which was missing some cases. Also change
.iter().next()->.first()when applicable.